Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags and Categories #239

Open
dshanske opened this issue Sep 9, 2020 · 4 comments
Open

Tags and Categories #239

dshanske opened this issue Sep 9, 2020 · 4 comments

Comments

@dshanske
Copy link
Member

dshanske commented Sep 9, 2020

Unit tests on adding categories and tags pass, but anecdotal information suggests problems.

Need to do some live testing and possibly expand the unit tests.

Also should other WordPress taxonomies be allowed in here?

@janboddez
Copy link
Contributor

Also should other WordPress taxonomies be allowed in here?

Could you make this filterable? Like, you could either allow a list of taxonomies and then try to fetch all terms, or simply allow filtering the final term list (which is probably easier). Asking because I use custom post types and taxonomies. :-) (Well, I don't really use taxonomies in combination with Micropub, yet, but it'd be a nice addition.)

@janboddez
Copy link
Contributor

janboddez commented Oct 5, 2020

Just now learning about the 'micropub_query' filter, which may suffice. (Hoping, in fact, to use this to add post-types support.)

@dshanske
Copy link
Member Author

dshanske commented Oct 5, 2020

@janboddez micropub_query is for querying the endpoint. You might want to look at micropub_post_type that allows you to set a custom post type for a Micropub post, based on other parameters.

Right now, the system looks for a category, and if it can't find one, looks for a tag, and if not, creates a tag. I was thinking of adding a search order to this section. But then there is a proposal about channels(indieweb/micropub-extensions#40) that gave me pause.

@janboddez
Copy link
Contributor

janboddez commented Oct 5, 2020

@janboddez micropub_query is for querying the endpoint. You might want to look at micropub_post_type that allows you to set a custom post type for a Micropub post, based on other parameters.

Yeah, I was somehow thinking about the config query. My bad. 🤦

(There's this post-types (~post kinds, I guess, in the WordPress-verse) param that I was trying to add support for, to get Indigenous to only show the kinds I'm looking to support. I'm already using micropub_post_type. Works a treat!)

And, you're right, actually creating custom taxonomy terms would be quite a bit harder. (Here, too, I was thinking only of the querying part ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants