Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant asignation on Sequences Matrix = operator #46

Open
Vicfero opened this issue Oct 16, 2018 · 1 comment
Open

Redundant asignation on Sequences Matrix = operator #46

Vicfero opened this issue Oct 16, 2018 · 1 comment
Milestone

Comments

@Vicfero
Copy link
Contributor

Vicfero commented Oct 16, 2018

https://github.com/scapella/trimal/blob/b240b070f0c9651761361bb3d55bd0e3c328558a/source/sequencesMatrix.cpp#L92

should be

matrix[i][j] = matrix[j][i];

@scapella
Copy link
Collaborator

Obviously it seems like a bug but ... shouldn't it be?

matrix[i][j] = old.matrix[i][j];

@nicodr97 nicodr97 linked a pull request May 4, 2023 that will close this issue
@nicodr97 nicodr97 added this to the 2.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants