-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position limits don't respect orientation #19
Comments
I've encountered this as well.... I'm wondering, since you seem to have a better notion of what's going on here - you wouldn't by chance be able to point me to the relevant lines of code where changes need to made would you? Personally, I don't like the close button at all, it seems redundant being as you can close the app from the notification try (and this code is buggy anyway), but I'd like to be able to fix this issue and have the player be able to go below the bottom of the screen without disappearing and also be able to move the player beyond the 1/2 point in landscape mode... any advice or tips would be helpful! |
I've kinda figured this out for myself... Removing these lines; allows me to move the player freely in landscape mode... The close button / dragging to the bottom is another issue. but I've worked around it, I've disabled it. So now I can drag the player to the bottom without it disappearing, no close button or that functionality. |
You seem to be restricting the x position to
min(screenResolution.x, screenResolution.y)-floatingWindow.width
and the y position to
max(screenResolution.x, screenResolution.y)-floatingWindow.height
regardless of the device orientation since on my tablet only used in landscape mode I can move the video below the bottom of the screen but not even to the middle of the screen so It can't be dragged onto the X to close it.
If I force the tablet into portrait mode the floating window behaves as it should.
The text was updated successfully, but these errors were encountered: