-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch more compile-time errors in CI #477
Comments
I think |
Okay, I haven't really looked into the details of what |
That sounds reasonable. |
Right now in CI, we just test
We should test more:
Note that we currently don't build with
-all-features
so, for example, thedynamic-instrumentation
feature and that whole crate are not built in CI at all.Furthermore, we should run the external tests,
./scripts/test_translator.py tests/
andimmunant/c2rust-testsuite
CI inside ofcargo test
. This not only simplifies testing workflows, but also hooks into external testing, such as crater runs.I think we should definitely add these at least by the time we move CI to GitHub Actions instead of Azure Pipelines, but preferably earlier, as
cargo clippy
is almost passing (#474), and once it is, I'd like to keep it that way.cargo fmt --check
cargo check --all-features
cargo build
RUSTFLAGS='-D warnings' cargo check --all-features
RUSTFLAGS='-D warnings' cargo build
RUSTFLAGS='-D warnings' cargo clippy --tests --all-features
(includescargo check
)RUSTDOCFLAGS='-D warnings' cargo doc --all-features --document-private-items --no-deps
cargo test
./scripts/test_translator.py tests/
cargo test -p c2rust-analyze
fails CI due to noFileCheck
#593PRs and Tracking Issues:
--all-features
,cargo fmt --check
,cargo check
,cargo test
,cargo doc
, andRUSTFLAGS=-Dwarnings
to CI #483clippy
in CI #594cargo test -p c2rust-analyze
in CI #608The text was updated successfully, but these errors were encountered: