Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web admin settings page number input broken #9361

Closed
1 of 3 tasks
NicholasFlamy opened this issue May 9, 2024 · 2 comments · Fixed by #9470
Closed
1 of 3 tasks

Web admin settings page number input broken #9361

NicholasFlamy opened this issue May 9, 2024 · 2 comments · Fixed by #9470
Labels
bug Something isn't working 🖥️web

Comments

@NicholasFlamy
Copy link
Contributor

NicholasFlamy commented May 9, 2024

The bug

The number input field value is changed to the minimum when going under the minimum value and changed to the maximum when going over the maximum value. This is intended. The problem with this is that if you try and backspace the value to type in a new one, it'll become 0 and instantly update to the minimum.

What should happen is it waits until you tap outside of the input box (deselecting/defocusing the box) so that you're able to set the value.

Note: Ignore the fact I'm in an unreleased part of the settings, this applies to the other settings with number inputs, including job concurrency, Image Quality, ML Settings, etc.

This screenshot is where I hit backspace on the value and it instantly resets to the minimum:
Screenshot_20240509_125740_Chrome

This is the only workaround, putting your cursor in front or behind the value and typing some digits to make it your value with the old value now added to yours and you can backspace what was the old value:
Screenshot_20240509_125823_Chrome

The OS that Immich Server is running on

N/A

Version of Immich Server

All

Version of Immich Mobile App

N/A

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

N/A

Your .env content

N/A

Reproduction steps

1. Go to administration page.
2. Open a menu like Machine Learning and go to one of the options with a number.
3. Backspace the number and see the minimum keeps appearing when you hit backspace. 
...

Relevant log output

No response

Additional information

I'm using a Samsung Galaxy S21 on Android 14 with Google Chrome. Also tested on Brave on Linux Mint.

@NicholasFlamy
Copy link
Contributor Author

Oh also, this is the code handling the number input and the setting of the minimum/maximum value:

https://github.com/immich-app/immich/blob/main/web/src/lib/components/shared-components/settings/setting-input-field.svelte#L31

@NicholasFlamy NicholasFlamy changed the title Web admin settings page number input broken on mobile Web admin settings page number input broken May 9, 2024
@NicholasFlamy
Copy link
Contributor Author

Big edit:
I realized the desktop has the same problem. I'm just dumb and didn't check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🖥️web
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants