Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parties #24

Draft
wants to merge 30 commits into
base: production
Choose a base branch
from
Draft

Parties #24

wants to merge 30 commits into from

Conversation

panreach
Copy link
Contributor

@panreach panreach commented Nov 7, 2023 •
edited

Closes #23

  • basic CRUD for parties
  • Fix auto add user to party after login/create-account from share link
  • Add phpunit tests
  • Allow fulfillment viewing from parties page with mass toggle?
  • Add easy way for legacy users to add their non-party wishlist to a party.
  • ...

@imacrayon imacrayon mentioned this pull request Nov 7, 2023
Closed
panreach
panreach commented Nov 8, 2023
View reviewed changes
routes/web.php Outdated Show resolved Hide resolved
imacrayon
imacrayon reviewed Nov 9, 2023
View reviewed changes
routes/web.php Outdated Show resolved Hide resolved
database/migrations/2023_11_07_011743_create_parties_table.php Outdated Show resolved Hide resolved
@panreach
Merge remote-tracking branch 'upstream/production' into 23-parties
e50d05a
@panreach
Add settings to use address/dates. Default to false.
7d707bb
@panreach
Finish basic CRUD routes
f7569b6
@panreach
Change party viewers to participants.
2615791
@panreach
Fix weird hover link issue caused by
1736d0b
@panreach
Fix controller include
503412d
@panreach
Fix joining party to create wishlist and relations.
b97c655
@panreach
don't show user in joinedParties if created by user
093b444
@panreach
add TODO allow participants in same party to view all assigned wishlists
d5ba46c
@panreach
Instead of allowing wishlists to belong to multiple parties, just all…
275dd0d 
…ow a wishlist to belong to one party. This makes policies easier.
@panreach
Add/Fix remove party participant functionality/route.
af28b1f
@panreach
Fix auto add user to party after login/create-account from share link
fa769e4
@panreach
Check if party exists in wishlist policy
c955c91
@panreach
Add choose-adventure route and functionality. Allow a user to choose …
11fa2fc 
…between creating a party or a wishlist on account creation.
@panreach
Merge remote-tracking branch 'upstream/production' into 23-parties
1e4be75
@panreach
remove duplicated parameter
af7f2ea
@panreach
Match new wishlist action for new party.
d6de998
@panreach
Fix duplicate party wishlist creation.
915e3bd
@panreach
Add parties to navigation
dfd28fb
@panreach
Add kick to party participants.
5c373a6
@imacrayon
Copy link
Owner

Hey @panreach I realized we pushed quite a few changes lately that conflict with some of the stuff you're working on in this PR. It looks like the on-boarding process for parties might require some reworking to fit with some of new layout and guest user features specifically. I think parties would still be a nice feature to support, so if you don't mind, I'll work on resolving the conflicts in this PR and try to sort out at least a basic version we can ship soon. It feels like this is 80% of the way there, thanks for all your work on it so far!

@panreach
Copy link
Contributor Author

I think parties would still be a nice feature to support, so if you don't mind, I'll work on resolving the conflicts in this PR and try to sort out at least a basic version we can ship soon.

Go for it @imacrayon

@imacrayon imacrayon marked this pull request as draft December 2, 2023 15:15
@imacrayon imacrayon changed the title WIP: Parties Parties Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imacrayon imacrayon imacrayon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parties / Gatherings / Multiple Wishlists
2 participants
@panreach @imacrayon