-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL language causes history progress indicator to reverse #4906
Comments
low-batt
added a commit
that referenced
this issue
May 3, 2024
This commit will add an awakeFromNib method to the HistoryProgressCellView class that sets the progress indicator property userInterfaceLayoutDirection to be leftToRight. This prevents the indicator from reversing direction when a RTL language is configured.
2 tasks
2 tasks
uiryuu
pushed a commit
that referenced
this issue
May 24, 2024
This commit will add an awakeFromNib method to the HistoryProgressCellView class that sets the progress indicator property userInterfaceLayoutDirection to be leftToRight. This prevents the indicator from reversing direction when a RTL language is configured.
uiryuu
pushed a commit
that referenced
this issue
May 25, 2024
This commit will add an awakeFromNib method to the HistoryProgressCellView class that sets the progress indicator property userInterfaceLayoutDirection to be leftToRight. This prevents the indicator from reversing direction when a RTL language is configured.
Should close as resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System and IINA version:
Expected behavior:
IINA adheres to Apple's Internationalization and Localization Guide which specifies that timeline indicators should not flip in a right-to-left language.
Actual behavior:
Currently IINA does not support any right to left languages. However PR #4922 enables Hebrew. If you build IINA with that pull request and set Hebrew as the language then the progress indicator in the history window changes direction as seen here:
This problem was reported by @ShlomoCode in issue #4776. As that issue reports quite a few RTL related problems I have created this issue to focus just on this problem.
Steps to reproduce:
Product
menu open theScheme
menu and selectEdit Scheme…
Options
tabApp Language
settingRight-to-Left Pseudolanguage
near the end of the listPlayback History
under theFile
menuPlayback History
window appearsOr you can build with PR #4922 and set your language to Hebrew.
mpv does not support localization.
How often does this happen?
Every time.
The text was updated successfully, but these errors were encountered: