-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Product Category can be recreated with the same name, description & color tag. #1074
Comments
Hey @MehdiMsa I replicated the issue, and I would like to work on it, can you please assign it to me. |
i also replicated the issue and i would like to work on it if u haven't started @yashashvi007 or we could work on it together if you would like |
Okay, @Houssemdaoud let's do this together, i looked into the code it doesn't seems to be a complex one, but already started working on it. |
One question @MehdiMsa, on what parameters the uniqueness should be based on. Like should i consider name only because that will also work. |
I think the uniqueness should be based on the color |
@yashashvi007 @Houssemdaoud hello, feel free to take part of this work. I already started working on this issue 2 days ago & I would be happy to share the work with you. |
Hey @yashashvi007, I do believe that only contributors with writers privilege can assign tasks for the issues. Nonetheless, feel free to take part on this task. |
Hey @MehdiMsa
Yes i would love to see your work on this one, I also done some work on it, I too love to share my work. |
hello @yashashvi007 @MehdiMsa is this issue worked on ? |
@marammahfoudhi yes maram, I already fixed this issue. Nonetheless, I'm facing some issues pushing the code. Will be fixed by this week atmost. |
Hello Mhedi, I reproduced the issue and I'm facing the same problem, thanks for highlighting it. |
Did you push it yet? |
Thank you for testing it out. I already pushed a fix for the solution in the following pull request:
Yes indeed, you will find attached above the link to the changes made. Feel free to leave a code review. It will be very helpful. |
Describe the bug
This problem is whenever a certain product category is created. Eventually the same product category could be recreated with same name, description & tag. In which, it will lead to a confusion when creating a new product.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A Message Suggesting that Product Category Already Exists
Screenshots
Desktop (please complete the following information):
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: