Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product Category can be recreated with the same name, description & color tag. #1074

Open
MehdiMsa opened this issue Apr 21, 2024 · 14 comments

Comments

@MehdiMsa
Copy link

MehdiMsa commented Apr 21, 2024

Describe the bug
This problem is whenever a certain product category is created. Eventually the same product category could be recreated with same name, description & tag. In which, it will lead to a confusion when creating a new product.

To Reproduce
Steps to reproduce the behavior:

  1. Login to https://cloud.idurarapp.com/
  2. Go to 'Products Category Section'
  3. Click on 'Add New Product Category'
  4. Fill in the information & create the Product Category
  5. Click on 'Add New Product Category'
  6. Recreate another Product Category with the same data

Expected behavior
A Message Suggesting that Product Category Already Exists

Screenshots
image
image

Desktop (please complete the following information):

  • OS: Windows 11 Pro
  • Browser: Google Chrome
  • Version

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version 123.0.6312.124 (Official Build) (64-bit)
@MehdiMsa
Copy link
Author

Same goes for the Product Section, the Products could be duplicated too.
image

@yashashvi007
Copy link

Hey @MehdiMsa I replicated the issue, and I would like to work on it, can you please assign it to me.

@Houssemdaoud
Copy link

Hey @MehdiMsa I replicated the issue, and I would like to work on it, can you please assign it to me.

i also replicated the issue and i would like to work on it if u haven't started @yashashvi007 or we could work on it together if you would like

@yashashvi007
Copy link

yashashvi007 commented Apr 22, 2024

Okay, @Houssemdaoud let's do this together, i looked into the code it doesn't seems to be a complex one, but already started working on it.

@yashashvi007
Copy link

One question @MehdiMsa, on what parameters the uniqueness should be based on. Like should i consider name only because that will also work.

@Houssemdaoud
Copy link

One question @MehdiMsa, on what parameters the uniqueness should be based on. Like should i consider name only because that will also work.

I think the uniqueness should be based on the color
Because we can have multiple food but different colors

@MehdiMsa
Copy link
Author

@yashashvi007 @Houssemdaoud hello, feel free to take part of this work. I already started working on this issue 2 days ago & I would be happy to share the work with you.
And as @Houssemdaoud, the product category is classified through color selection as you mentions. By which I think could be considered as a parameter of uniqueness.

@MehdiMsa
Copy link
Author

Hey @MehdiMsa I replicated the issue, and I would like to work on it, can you please assign it to me.

Hey @yashashvi007, I do believe that only contributors with writers privilege can assign tasks for the issues. Nonetheless, feel free to take part on this task.

@yashashvi007
Copy link

Hey @MehdiMsa

@yashashvi007 @Houssemdaoud hello, feel free to take part of this work. I already started working on this issue 2 days ago & I would be happy to share the work with you. And as @Houssemdaoud, the product category is classified through color selection as you mentions. By which I think could be considered as a parameter of uniqueness.

Yes i would love to see your work on this one, I also done some work on it, I too love to share my work.

@marammahfoudhi
Copy link
Contributor

hello @yashashvi007 @MehdiMsa is this issue worked on ?

@MehdiMsa
Copy link
Author

@marammahfoudhi yes maram, I already fixed this issue. Nonetheless, I'm facing some issues pushing the code. Will be fixed by this week atmost.

MehdiMsa added a commit to MehdiMsa/idurar-erp-crm that referenced this issue May 5, 2024
@Ouchi-Ranim
Copy link

Hello Mhedi, I reproduced the issue and I'm facing the same problem, thanks for highlighting it.

@Ouchi-Ranim
Copy link

Did you push it yet?

@MehdiMsa
Copy link
Author

MehdiMsa commented May 11, 2024

Hello Mehdi, I reproduced the issue and I'm facing the same problem, thanks for highlighting it.

Thank you for testing it out. I already pushed a fix for the solution in the following pull request:
https://github.com/idurar/idurar-erp-crm/pull/1094/commits/d3b10928d0884116ad8d85ef9c25f57be2763073

Did you push it yet?

Yes indeed, you will find attached above the link to the changes made. Feel free to leave a code review. It will be very helpful.
Thank you & have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants