Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torrt doesn't download just incremental files but all of them once again #21

Open
GentleHoneyLover opened this issue May 15, 2018 · 9 comments
Labels

Comments

@GentleHoneyLover
Copy link

Hello,

Thx for the great app — it works great so far! One minor annoyance, though (and I'm not sure if this is by design or a bug).

I use Deluge and Filebot plugin with it. Upon download competition, Filebot (via Deluge plugin) renames files and moves them from my Downloads folder to TV Shows folder.

When torrt performs a walk, it removes the existing torrent from deluge and adds an updated one — but it doesn't instruct deluge to download only the new file — it downloads everything again. If files downloaded from original torrent were not renamed and moved that would not be an issue — deluge would detect existing files. But in my case, because original files were moved, deluge (naturally) downloads everything again.

Is there any way around my issue? Can support for such scenario be implemented in the next torrt release?

Thx in advance!

@ALTracer
Copy link
Contributor

@pavstor , why would you want to rename torrent content files?
I suggest leaving media intact, downloading directly into storage folder, and then simply re-checking hashes upon updating.
If you want deluged to use renamed files, consider reading Filebot plugin documentation. This is hardly doable and would require weird hooks.

@idlesign
Copy link
Owner

idlesign commented May 15, 2018

Hi, @pavstor. Thank you.
Just as @ALTracer said: torrt supports only relocation (i.e. moving from one folder to another should be fine) but not renaming, since there's no way to reliably determine from torrt which file was renamed into what outside of it.

@GentleHoneyLover
Copy link
Author

Hi @ALTracer, @idlesign, thx for the additional context!

The way Filebot plugin seems to be working is that it renames and moves files (per pre-defined rules) and reports it back to Deluge — Deluge knows new location and naming of the files and keeps seeding as it normally would.

A screenshot below is a good example:

image

This is a completed torrent that has been processed by Filebot (through Deluge plugin). The first 4 files are not renamed because they were not downloaded. The last one was renamed and moved from /Downloads/ to /TV Shows/Fear the Walking Dead/Season 4/. The new path and names were updated from within the torrent in Deluge and it keeps seeding as if no renaming/moving happened.

Is it possible to make torrt read the new path and filenames from the existing torrent during the walk and then set the same path and filenames for already downloaded files in the updated torrent?

@idlesign
Copy link
Owner

idlesign commented May 15, 2018

Is it possible to make torrt read the new path and filenames from the existing torrent during the walk and then set the same path and filenames for already downloaded files in the updated torrent?

With something like https://github.com/idlesign/deluge-updatorr it would be possible, since being a plugin it has an access to Deluge data; otherwise hard to say, needs investigation. Per file download location may even be unsupported in some clients not to mention client API abilities.

@GentleHoneyLover
Copy link
Author

Maybe could be implemented via a plugin :)

Thx for looking into this! Would be great if this capability could be implemented at some point. This is the last mile that doesn't allow me to achieve a fully automated home media center setup :)

@ALTracer
Copy link
Contributor

ALTracer commented May 15, 2018

@pavstor, have you been to @Laharah/deluge-FileBotTool repo? Weirdly they never filed issues with ongoing updating torrents (like TV Series).

For now you may want to drop a script in crontab to

  • call torrt walk --dry-run (do we have this, @idlesign?) and grep magic to detect update candidates, if any;
  • rollback/undo renames via FileBot History per torrent for each update candidate (just so deluged finds the ready episodes), check hashes;
  • call torrt walk -f;
  • rename again immediately and upon downloading. I just hope all of this happens to be stored on a single disk.

add, off-topic:
So you want to download into a separate /media/Download folder and then move into /media/TVSeries/$soap/$season and seed from there? What's the point? deluged allows to append .part file extension to non-ready media, and all modern Home media centers I know (thanks, Kodi!) run a db and process all sorts of filenames just so end-user/watcher never sees them.

@idlesign
Copy link
Owner

idlesign commented May 16, 2018

call torrt walk --dry-run (do we have this, [...]

Nope, we have none. It's hard to elaborate on an actual degree of dryness that should be implemented.

@GentleHoneyLover
Copy link
Author

@ALTracer, thx for the tip! Didn't know Filebot was capable of rolling renaming back based on history — I will look into this. Maybe I'll find a use for that. However, the workflow you laid out seems overly complex. I was hoping to find more of a plug-n-play solution :)

Not sure I get your off-topic comment, though. I keep my media organized in a specific folder structure (movies, tv shows, music videos, etc.) in order for Plex to pick everything up correctly and reflect in various media libraries. I also rename files themselves to minimize the risk of Plex not recognizing them (sometimes downloaded files have very weird naming). I found a way to automate this via Filebot (using a plugin for Deluge).

@alexlitvinenko
Copy link
Contributor

Hi,
Let me share my solution: I do not rename files but use symbolic links with name understandable by plex. My Plex Media server is pointed to directory with symbolic links. I've written script that creates all symbolic links on "Torrent Complete" event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants