-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fails without clear warning/error on processing !system command #40
Comments
Is there really no error message in either the default output pane or the developer console? It's a bit difficult to debug without knowing more about your setup, so maybe you could answer the following questions:
I also wonder, if this is related to this unresolved issue: #29 |
Regarding unresolved issue #29 , I have encountered similar issues in the same code I referred above. The following line will always throw an error during preprocessing:
However, when running it with MakeNSIS, all compiles fine. The reason for this behaviour is that the pre-processor seems to be checking if the file that is referenced (located in the C:\TMP-folder) actually exists. Which it should not do, in my case, since it is created and populated by the previous |
Are you talking about the PPO flag of |
Hi @idleberg , excuses for reviving this old issue, but today I ran into it again and I have no option to circumvent it this time. Because of changes in our build environment / Jenkins setup, I need to load specific tools/data from a location that is saved in the system's environment variables. The following code works perfectly when ran from
This throws the following error (even though the file exists in that repository location):
Behaviour does not change when code.exe is launched from command line. It also marks the line as containing an error: |
I'm encountering this same issue. It seems to happen with ANY calls to !system, not just file actions. Works fine in MakeNSISW, but dies as soon as it hits the !system line in VSCode with no errors being reported. |
Also worthy of note, !appendfile works fine, so it's not running in the wrong mode (PPO). Only !system is failing out. |
@ShadowDrakken So the following script does not work for you? Script !system "echo 'Hello World'"
OutFile "demo.exe"
Unicode false
Section
SectionEnd Output
However, take note of the following two things as they might have a impact:
Would you be so kind and compile the script as-is and with |
Happens on both Windows 10 and Windows 11 with Unicode set to either true or false. I've set the Verbosity to 4, otherwise it just dies after the header with no information at all
And just dies there. No errors and the MakeNSIS process is gone |
Description
Compilation using the NSIS Extension in VS Code fails on processing a !system compile-time command. My script is trying to calculate some files' checksums on compilation time so it can later on see if it downloads those files from a server correctly by checking it.
Steps to Reproduce
Expected behavior:
Compilation should calculate the MD5-checksum of the file, write it to the txt file and then load the content of that txt-file into the define named ${TOOLKITHASH}. It should then, for debugging purposes, echo the checksum to the output terminal.
The expected output should be (for the file I'm testing)
MakeNSIS does it correctly for this script, without warnings or errors:
Actual behavior:
Compilation fails without clear error on the first !system command. Verbosity is set to 4 in the settings, diagnostics preprocess mode is set to 'none'.
Reproduces how often:
100 % of the time.
Versions
OS: Windows 10 v20H2 Build 19042.685
VS Code: 1.67.2
NSIS: v3.08
NSIS Extension: v3.49.0
(there was an issue with 3.50 which prevented anything from compiling so I rolled back the install yesterday)
The text was updated successfully, but these errors were encountered: