Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combiner generator should not always merge sidesets and boundaries #27646

Closed
GiudGiud opened this issue May 16, 2024 · 1 comment · Fixed by #27647
Closed

Combiner generator should not always merge sidesets and boundaries #27646

GiudGiud opened this issue May 16, 2024 · 1 comment · Fixed by #27647
Assignees
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

Motivation

Carolina was trying to have several parts of a circle be meshed independently then combined while preserving boundaries.

But the combiner merges everything with the same ids.

Design

So either:

  • force users to see it merged, be unhappy, then use a RenameBoundary/BlockGenerator then it works
  • add offset id/names features to EVERY SINGLE mesh generator (you do that not me)
  • add simple offsets to the merge generator that combine (combiner first, maybe stitcher soon)

Impact

Easier mesh generation workflows

@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. C: Meshing MeshGenerator system, mesh loading labels May 16, 2024
@GiudGiud GiudGiud self-assigned this May 16, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 16, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 16, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 16, 2024
@GiudGiud
Copy link
Contributor Author

Actually I might do option 2 for the subdomains of a GMG. I kind of could use it for making a bunch of cylinders.
But in general I think not-merging is the way to go, less efforts for the same result

GiudGiud added a commit to GiudGiud/moose that referenced this issue May 16, 2024
ke7kto pushed a commit to ke7kto/moose that referenced this issue May 22, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 24, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 24, 2024
GiudGiud added a commit to GiudGiud/moose that referenced this issue May 24, 2024
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 4, 2024
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 4, 2024
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 4, 2024
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant