-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Quadratic Elems in XYDelaunay and Related MGs #27546
Conversation
Job Documentation on c27f819 wanted to post the following: View the site here This comment will be updated on new commits. |
Job Coverage on c27f819 wanted to post the following: Framework coverage
Modules coverageReactor
Full coverage reportsReports
This comment will be updated on new commits. |
This PR is expected to have conflicts with #27434 so I will fix after that one is merged. @roystgnr Currently, four manual options (TRI3, TRI6, TRI7 and DEFAULT) are provided as you directed. If the generated elements and input elements do not have the same orders, it should be "okay" if we do not stitch the holes. But if holes are stitched:
Any ideas/preferences would be appreciated. |
We definitely don't want to automatically convert any higher-order inputs to first-order if they're going to be used for stitching; that's a good place to throw an error. It looks like we don't currently have any MOOSE If higher-order meshes are only going to be used for boundary/hole definition ... that's the situation where I think we want to explicitly require users to specify And if we have mixed order between different inputs? My first instinct is that we should have a |
Thanks, @roystgnr I will add the error messages accordingly. For |
We already have |
d8a946b
to
a700278
Compare
My vote would be for a single ConversionGenerator, with parameters to select the new order; that's just more flexible than the current mesh class parameter. We may have a mix of quadratic-capable and quadratic-incapable generators in an input, and in that case it might be useful to be able to select exactly where in the mesh generator tree we bump up the order - too early and the incapable generators can't handle it; too late and the capable generators need to all be mixed-order-input-capable too, which is a bit of an ask. |
Same vote. An ElementOrderConversionGenetor with block-restriction will cover all our needs |
I am not sure if we want to do block restriction here. I guess a mixed-order mesh would be an issue in most cases. |
Job Precheck on 5cceb02 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Job Apptainer moose on 3f4bd39 : invalidated by @miaoyinb |
@GiudGiud Just a friendly reminder. Your review would be greatly appreciated. |
@GiudGiud will be on travel. If he wants to remove himself from assignment, then we might review this faster |
Thanks @lindsayad . It would be up to @GiudGiud. I just want to make sure this PR is not forgotten. |
framework/doc/content/source/meshgenerators/ElementOrderConversionGenerator.md
Show resolved
Hide resolved
Let's assume I can't get to it before I come back in 2 weeks. Not sure yet |
I'll review if @GiudGiud doesn't mind. |
Go ahead. GH isn’t even loading on the plane Le 23 mai 2024 à 13:19, roystgnr ***@***.***> a écrit :
I'll review if @GiudGiud doesn't mind.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can clarify a few things in docs and error messages but that's arguable and this is a big improvement as-is.
I will add more docs late today. |
Let me kick those failing tests; looks to me like they just happened to coincide with some planned github.inl.gov downtime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to wait for those kicked tests to finish, or for anyone else who wants to chime in, but we should merge today if there aren't any surprises.
closes #27545
Reason
Design
Impact