Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be more forgiving in configured dns names #56

Open
icing opened this issue Oct 20, 2017 · 2 comments
Open

be more forgiving in configured dns names #56

icing opened this issue Oct 20, 2017 · 2 comments
Labels
enhancement

Comments

@icing
Copy link
Owner

icing commented Oct 20, 2017

ServerName and ServerAlias names may carry port numbers, as in greenbytes.de:443 and mod_md needs to strip those silently when matching MDs against vhosts.
@randolf
Copy link

randolf commented Nov 6, 2018

The ServerName does support that, but according to the documentation the ServerAlias directive does not:

https://httpd.apache.org/docs/2.4/mod/core.html#serveralias

@icing
Copy link
Owner Author

icing commented Nov 6, 2018

You are correct. The ServerName needs to be normalized in checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icing @randolf