-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
discussion: use order_float instead of f32,f64 #116
Comments
I'm open with using
Maybe we should do something extra here instead of store |
We may need to implement customized ordering trait, hash function. |
There are two problem in https://crates.io/crates/ordered-float
I guess the only solve way is to maintain our own ordered_float. |
Maybe it's easier to implement |
Do you means that implement the custom behaviour in PrimitiveValue🤔, like
|
LGTM. |
To support partition write, we need something like
HashMap<StructValue,_>
. So this means that we need to impl Eq for AnyValue. To do this, we need to replace f32, f64 to order_float. (e.g. https://crates.io/crates/ordered-float)As https://internals.rust-lang.org/t/f32-f64-should-implement-hash/5436/33#:~:text=If%20you%20want%20to%20have%20a%20content%20hash%20of%20a%20struct%20that%20includes%20floats says, to support Hash for the struct, we also can use serde. But I guess there may be other scenes we need Eq.
The text was updated successfully, but these errors were encountered: