Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to immer@10+ breaks react native + hermes builds #5644

Open
josephmr opened this issue May 1, 2024 · 0 comments
Open

Update to immer@10+ breaks react native + hermes builds #5644

josephmr opened this issue May 1, 2024 · 0 comments

Comments

@josephmr
Copy link
Contributor

josephmr commented May 1, 2024

Description
The update to "immer": "^10.0.3" in #5528 prevents Slate from building in react native projects that utilize the hermes engine. The newer version of immer utilizes some features which are not implemented in hermes yet.

We utilize Slate in react native to build and normalize documents that match our web application even though we don't use it to control an actual input element.

Steps
To reproduce the behavior:

  1. Add Slate as a dependency to a React Native project
  2. Enable hermes engine
  3. Attempt a release build of the application

Expectation
I'm unsure if Slate should take any action here. We are working around the issue by pinning immer to 9.0.21 and forcing slate to use that version. This currently works because slate hasn't updated any usages of immer so it is still compatible with 9.0.21.

This is largely an FYI issue for others. Additionally, resisting any immer 10+ backwards incompatible code might want to be avoided to continue supporting react native and older browser usages until strictly necessary.

Environment

  • Slate Version: 0.102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant