-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Replace and Collapse on Escape not working in example page. #45
Comments
I'm pretty sure what you describe as the current behaviour for collapse on escape is the expected behaviour. |
Really? Then isn't Deselect On Escape perhaps a more descriptive name? Collapse made me think somehow the selected text would actually collapse, and could then be expanded again. Much like you can collapse/expand blocks of code. (Not trying to be picky just for the sake of being picky...) |
Can confirm the Should be easy to fix by replacing: AutoReplace({
trigger: 'space',
before: /^(#)$/,
change: (change, e, matches) => change.setBlocks({ type: 'h1' })
}) with: AutoReplace({
trigger: 'space',
before: /^(#)$/,
change: (change, e, matches) => change.setBlocks('h1' )
}) |
It would be a more explicit name, yes! How you interpreted 'collapse' is definitely understandable. |
Do you want to request a feature or report a bug?
Bug. (on the examples website https://slate-plugins.netlify.com/#/slate-auto-replace)
What's the current behavior?
Collapse on escapeWhen selecting some text, then hitting escape. The text is deselected, and nothing else happens.What's the expected behavior?
Collapse on escapeI actually have no idea.Update: May 11, 2019
It seems that "Collapse on escape" is working as expected.
The text was updated successfully, but these errors were encountered: