Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using ESLint rule: default-case #34

Open
Nantris opened this issue Oct 28, 2018 · 0 comments
Open

Consider using ESLint rule: default-case #34

Nantris opened this issue Oct 28, 2018 · 0 comments

Comments

@Nantris
Copy link
Contributor

Nantris commented Oct 28, 2018

Do you want to request a feature or report a bug?

Feature (DevOps)

What's the current behavior?

Switch statements do not require a default case

What's the expected behavior?

If the past when returning undefined moved through the plugin stack this would definitely be overkill, but it might be worth considering now.

If we require a default case, it would probably help with ensuring that we are always returning next() where needed - This might be worth implementing in Slate itself as well with the recent changes.

https://eslint.org/docs/rules/default-case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant