Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validity check during import #7

Open
Wikxen opened this issue Sep 13, 2019 · 2 comments
Open

Add validity check during import #7

Wikxen opened this issue Sep 13, 2019 · 2 comments
Assignees
@Wikxen
Labels
enhancement New feature or request

Comments

@Wikxen
Copy link
Member

Wikxen commented Sep 13, 2019 •
edited

By using libphonenumber.
This was brought to light in #6
@Wikxen Wikxen added the enhancement New feature or request label Sep 13, 2019
@Wikxen Wikxen mentioned this issue Sep 16, 2019
Merged
@Wikxen
Copy link
Member Author

Wikxen commented Sep 17, 2019

Maybe also add a script that runs the validation on the existing numbers and removes invalid? Kinda like reverse import.js.

@brolaugh brolaugh reopened this Sep 17, 2019
@brolaugh
Copy link
Contributor

We could also make validation of the list part of the import process.

@Wikxen Wikxen assigned Wikxen and unassigned brolaugh Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wikxen Wikxen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wikxen @brolaugh