Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report max RSS as part of compare_benchmarks #2301

Open
mrks opened this issue Jan 11, 2021 · 1 comment
Open

Report max RSS as part of compare_benchmarks #2301

mrks opened this issue Jan 11, 2021 · 1 comment
Labels

Comments

@mrks
Copy link
Member

mrks commented Jan 11, 2021

In #2294, I almost introduced significant memory costs. I wonder if we should store the Max RSS (getrusage / ru_maxrss, no idea about Mac) in the benchmark JSON and make that part of the compare_benchmark output. If yes, we should make sure that it is visible for benchmark_all even without unfolding the system comparison part.

@mrks
Copy link
Member Author

mrks commented Jan 31, 2021

We can probably reuse code from MetaSystemUtilizationTable or add MaxRSS over there and simply drag it into the output JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants