Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jt-nti in the right places #238

Closed
ryjones opened this issue Apr 12, 2024 · 3 comments
Closed

Add jt-nti in the right places #238

ryjones opened this issue Apr 12, 2024 · 3 comments
Assignees

Comments

@ryjones
Copy link
Member

ryjones commented Apr 12, 2024

@jt-nti needs access restored. However, he is only listed as emeritus maintainer in Fabric repos (which is why I removed him). @denyeart please file a PR and add him in the proper maintainer files

@denyeart
Copy link
Contributor

I don't think James is a maintainer of any hyperledger repositories anymore (beyond some hyperledger-labs), but he remains a trusted advisor for several repositories.

It looks like who can approve is an org setting:

https://github.com/hyperledger/fabric-protos/settings/code_review_limits
✓ Limit to users explicitly granted read or higher access

Note that only @hyperledger/fabric-core-maintainers members can merge in this repository based on CODEOWNERS, but it would still be nice to allow others to indicate approval.

I see a team called read-only with 314 members. Is the read-only team all members of the Hyperledger organization? What is the criteria for adding people to each? I know to assign issues to people they must be a member of Hyperledger organization. For example I should be able to assign an issue to James even though he is not a maintainer. So I think we'd want to be liberal about Hyperledger org membership. Are you removing all non-maintainers from these lists?

@ryjones
Copy link
Member Author

ryjones commented Apr 12, 2024

yes, the read-only team is all members. I suggest making a fabric-triage team, or similar, and adding yourself as a maintainer and James (and other trusted people) to that team, as well as read-only.

We used to be very liberal with org membership, but it has caused us a problem in the past. That's why read-only exists. There will be a future complication which I can't discuss yet which means I need to keep the list pruned to trusted, active people.

@denyeart
Copy link
Contributor

@ryjones Good idea. In fact we already had a fabric-triage team.

#239

@ryjones ryjones closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants