Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orderer v3: update fabric-proto-go dependency #54

Closed
tock-ibm opened this issue Jun 5, 2023 · 4 comments
Closed

Orderer v3: update fabric-proto-go dependency #54

tock-ibm opened this issue Jun 5, 2023 · 4 comments
Assignees

Comments

@tock-ibm
Copy link

tock-ibm commented Jun 5, 2023

config protobuf messages changed with the new BFT work. The dependency below needs to be updated to reflect fabric main:
github.com/hyperledger/fabric-protos-go v0.0.0-20200424173316-dd554ba3746e

->

github.com/hyperledger/fabric-protos-go v0.3.0

also update to go 1.20

@tock-ibm tock-ibm changed the title Orderer v3: update proto-go dependency Orderer v3: update fabric-proto-go dependency Jun 5, 2023
@MayRosenbaum
Copy link
Contributor

I'll take it

@denyeart
Copy link
Contributor

denyeart commented Jun 13, 2023

Thanks @MayRosenbaum

Actually we'd like to move to github.com/hyperledger/fabric-protos-go-apiv2 v0.3.0 since fabric-admin-sdk uses fabric-protos-go-apiv2 and intends to pull in fabric-config dependency. See also #53.

@SamYuan1990 is it ok for fabric-admin-sdk to go to v0.3.0 as well? Hopefully that doesn't cause any problem supporting both Fabric v2.5 (protos v0.2.0) and Fabric v3.0 (protos v0.3.0).

@tock-ibm
Copy link
Author

@MayRosenbaum After some discussions, the path forward is to:

  • First move fabric-config to github.com/hyperledger/fabric-protos-go v0.3.0, in order to pick up the related BFT changes for v3.
  • Later, as part of a bigger move to upgrade fabric to github.com/hyperledger/fabric-protos-go-apiv2 v0.3.0, to change fabric-config to that implementation (see Use new (non-deprecated) protocol buffer bindings fabric#3650).

In this issue we'll handle the first part, #53 will be used for the second part.

@tock-ibm
Copy link
Author

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants