-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customize 24h vs 12h time formatting globally #29
Comments
Hi @MikeShi42 , can give resolving this issue a try? |
Sounds good! Let me know if you need any help or pointers :) Feel free to hop in on our Discord if there's some implementations ideas you want to chat about. I'd also mention we have a hook called useLocalStorage that can help persisting the settings. |
Hi @MikeShi42 , just want to let you know I'm still working on this, just needed some time to get familiar with the codebase. |
@MikeShi42 Is it completed? I would like to give it a try? |
Some users have a preference for 12h time instead of 24h time, today we do a mix of both depending on the UI they're looking at (sessions is primarily 12h, logs are primarily 24h) - we should allow users to globally toggle 12/24h time and update the time format across the app accordingly.
I've already started a bit of the implementation, but there is still a lot of way to go:
hyperdx/packages/app/src/SearchTimeRangePicker.tsx
Line 144 in 36cbc3d
Todo:
The text was updated successfully, but these errors were encountered: