Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore Project Configurations #68

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Chore Project Configurations #68

wants to merge 7 commits into from

Conversation

mym0404
Copy link

@mym0404 mym0404 commented Mar 27, 2024

Description

It seems to this library works well with plain react-native project not expo only.

Could we remove expo peer dependency in package.json?

Also, I configure some typo, dependencies in project.

Works

  • Remove expo from peer dependencies
  • Fix typo in CONTRIBUTING.md
  • Change eslint source.fixAll type true to explicit (recommended by vscode)
  • Format CONTRIBUTING.md

image

  • Fix test with bumping jest

The current project's jest test is broken. We meet this error.

 FAIL  __tests__/MasonryList.test.tsx
  ● Test suite failed to run

    TypeError: Cannot assign to read only property 'performance' of object '[object global]'

      at Object.<anonymous> (node_modules/react-native/jest/setup.js:419:20)

This is resolved by bumping jest to ^29.7.0

  • enforce organize imports on save

If user set source.organizeImports as always or explicit in their user settings.json, then the import order will be mixed on save during development.

We can enforce this by declare it in project settings.

Related Issues

Tests

None

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@mym0404 mym0404 changed the title Remove expo from peer dependency Chore Project Configurations Mar 27, 2024
@mym0404
Copy link
Author

mym0404 commented Mar 27, 2024

@hyochan could you review this? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inclusion of expo as a peer dependency is causing warnings Remove expo from peer dependencies
1 participant