Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns are unaligned from bottom when height of the images are not equal #16

Open
aliasad106 opened this issue Aug 27, 2021 · 6 comments
Labels

Comments

@aliasad106
Copy link

it seems like it just distributes number of items equally and doesn't take their heights in consideration.
I think it should make the distribution with respect to height.
Screenshot_20210827-171627

@hyochan hyochan added the 🥺 feature request Request a new feature label Aug 27, 2021
@hyochan
Copy link
Owner

hyochan commented Aug 27, 2021

Looks like we need extra work on organizing sizes in the array then check the current total height before adjusting the height of element.

The idea can be when adjustRespectiveHeight prop is true, we can have that.

@aliasad106
Copy link
Author

@hyochan in our scenario we have width/heights of each element already in our array. Our requirement is only 2 columns so may we can pre-sort it according to that but in multi-column that would be overhead.

@hyochan
Copy link
Owner

hyochan commented Sep 19, 2021

@aliasad106 We can try!! However, I am sorry that I have really busy days until Oct 17th 😢

@ruairioliverwv
Copy link

Thanks for this lib, works great! I'd also love to see this feature added if possible

@elliotsayes
Copy link

Same here, lacking this feature is a show stopper for me.. the longer the list gets the more unbalanced it can become :(

@thefranfran
Copy link

Same issue here, this issue block me :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants