New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
type: image content_source is useless #116
Comments
hey @codefalse thanks for raising this. While we define and attach the root source on line 102, that doesn't apply to the image type, which definitely looks like we aren't checking if the option exists outside of it being an data attribute. We'll work this fix into the next milestone release as it should be pretty straight forward (also needs attention from line 615 as well). As i'm not sure when that roll out might be, our recommendation for getting |
This's my options
but the code in line 685, to check data-modaal-content-source, href, src, or error.
so, My configuration(options.content_source) is useless. We should give priority to self.scope.source,
The text was updated successfully, but these errors were encountered: