Some areas outside video modal don't trigger modal close on click #111

geeseyj · 2018-08-19T01:56:30Z

On video modals, at various screen sizes the div.modaal-video-wrap is wider than the actual video. Screenshot below:

Clicks on that extra space won't close the modal since the event listener is listening for a click on div.modaal-inner-wrapper

This makes it unresponsive when it should close the modal like other outside clicks.

I've observed this on the demo site in various browsers.

I'll send a pull request after opening this ticket. 🙂

…be responsive to certain clicks outside videos Update so that if overlay_close is true and a user clicks outside the video on .modaal-video-wrap the modal will close.

…ponsive to certain clicks outside videos Update so that if overlay_close is true and a user clicks outside the video on .modaal-video-wrap the modal will close.

geeseyj changed the title ~~Some areas outside video modal doesn't trigger modal close on click~~ Some areas outside video modal don't trigger modal close on click Aug 19, 2018

geeseyj mentioned this issue Aug 19, 2018

Develop #112

Merged

danhumaan added the enhancement label Nov 6, 2018

danhumaan self-assigned this Nov 6, 2018

danhumaan added this to the v0.4.5 milestone Nov 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Some areas outside video modal don't trigger modal close on click #111

Some areas outside video modal don't trigger modal close on click #111

geeseyj commented Aug 19, 2018 •

edited

Some areas outside video modal don't trigger modal close on click #111

Some areas outside video modal don't trigger modal close on click #111

Comments

geeseyj commented Aug 19, 2018 • edited

geeseyj commented Aug 19, 2018 •

edited