Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI utils class cases seem to be incorrect #1600

Open
busycalibrating opened this issue Apr 29, 2024 · 3 comments
Open

CLI utils class cases seem to be incorrect #1600

busycalibrating opened this issue Apr 29, 2024 · 3 comments

Comments

@busycalibrating
Copy link

busycalibrating commented Apr 29, 2024

The cases for the DPOScriptArguments and SFTScriptArguments (as seen here) have the correctly capitalized DPO and SFT names, but in the downloaded codebase, it seems to be in camel-case, i.e.

@dataclass
class SftScriptArguments:
    ...

@dataclass
class DpoScriptArguments:
    ...

I'm currently running version 0.8.6, installed from pip, but you can also see this in the downloaded zip release of v0.8.6.

Does anybody else see this or is this something just affecting me?

@younesbelkada
Copy link
Collaborator

Hi @busycalibrating
Thanks for the issue, when searching into the codebase, only the capitalized DPO and SFT names are present:

https://github.com/search?q=repo%3Ahuggingface%2Ftrl+SftScriptArguments&type=code

https://github.com/search?q=repo%3Ahuggingface%2Ftrl+DpoScriptArguments&type=code

@busycalibrating
Copy link
Author

Can you check that this is true when you download the zip release I linked?

@busycalibrating
Copy link
Author

Bumping this as I'm still running into this. For context, here's what the file looks like when I download the release I linked above:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants