-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-compilation fails for custom target #1509
Labels
Comments
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm compiling tokenizers into a custom target that's not x86 nor unstable_wasm. I cannot use oniguruma but it would be possible to use the fancy-regex library instead.
Solution would be as simple as changing
tokenizers/src/utils/mod.rs
fromto
Since onig is enabled by default and unstable_wasm "requires" fancy-regex, this change would not break anything that I'm aware of.
It would only break if users didn't set either flag of the regex features or if they set both simultaneously.
This change would also make it easier to switch between regex implementations and provide new ones in the future.
I'm opening a pull-request with said changes, let me know if there are any issues with it
The text was updated successfully, but these errors were encountered: