Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After accelerate v0.28.0, the split_batches of class Accelerator became a unsettable property method #872

Open
eraser00 opened this issue Apr 8, 2024 · 2 comments

Comments

@eraser00
Copy link

eraser00 commented Apr 8, 2024

self.split_batches = split_batches

As the src code above, optimum-habana impl a subclass of Accelerator with some copied codes from an older version accelerate.

but after accelerate v0.27.2

Accelerator Accelerator

The spile_batches became a property method, which can't be set directly. That breaks optimum-habana working with any newer accelerate versions.

Maybe the requirements.txt should be updated with accelerate <= 0.27.2?

@SefaZeng
Copy link

Save my time

@regisss
Copy link
Collaborator

regisss commented Apr 11, 2024

That's already the case, Accelerate is pinned here:

"accelerate < 0.28.0",

If you have Accelerate v0.28, there is an issue in the way Optimum Habana was installed. Can you try again in a fresh environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants