Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to transformers 4.39.1+ #865

Closed
vidyasiv opened this issue Apr 4, 2024 · 4 comments
Closed

Update to transformers 4.39.1+ #865

vidyasiv opened this issue Apr 4, 2024 · 4 comments

Comments

@vidyasiv
Copy link
Contributor

vidyasiv commented Apr 4, 2024

Feature request

If an update is already planned, could you please let us know the expected timeline. We had begun working on this and found we needed a more changes (that could also affect other models) than we were comfortable making at once.

Motivation

In order to enable CohereForAI/c4ai-command-r-v01 an update is needed to v4.39.1

Your contribution

Part of the upgrade work can be found (very cohereforai specific) : https://github.com/vidyasiv/optimum-habana/tree/cohereforai (only works for batch size=1 for run_generation.py) and higher batch sizes fail as it needs further changes.
Contributors: @skavulya and @vidyasiv

@vidyasiv vidyasiv changed the title Update to transformers 4.39.0+ Update to transformers 4.39.1+ Apr 4, 2024
@regisss
Copy link
Collaborator

regisss commented Apr 5, 2024

Transformers v4.40 should be released soon so I'll work on directly jumping from 4.38 to 4.40

@vidyasiv
Copy link
Contributor Author

Thanks @regisss , do you have a rough estimate of when that could be i.e end of April or earlier etc?

@regisss
Copy link
Collaborator

regisss commented Apr 26, 2024

I'll push a branch compatible with Transformers v4.40 next week. If there is no major regression, it should be merged a few days after.

@regisss
Copy link
Collaborator

regisss commented Jun 4, 2024

Upgraded to Transformers v4.40 in #1027.

@regisss regisss closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants