Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDXL] Update ControlNet training example to zero out embeds for empty captions #7976

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

bghira
Copy link
Contributor

@bghira bghira commented May 18, 2024

What does this PR do?

Fixes #7920

Before submitting

Who can review?

@sayakpaul @yiyixuxu @linoytsaban

@bghira bghira force-pushed the feature/zero-uncond-embed-controlnet-sdxl branch from 892e58d to fb21753 Compare May 18, 2024 17:01
…y captions, following upstream model behaviour
@bghira bghira force-pushed the feature/zero-uncond-embed-controlnet-sdxl branch from fb21753 to 84d97d9 Compare May 18, 2024 17:01
…y captions, following upstream model behaviour
@bghira bghira force-pushed the feature/zero-uncond-embed-controlnet-sdxl branch from 42bdd74 to 3cc99ad Compare May 18, 2024 17:02
Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sayakpaul
Copy link
Member

This only becomes effective, though when you enable proportion_empty_prompt which I agree is important for ControlNet training.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

training example for instruct pix2pix doesn't zero out embeds
3 participants