Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flax's use_memory_efficient_attention is broken #7895

Open
entrpn opened this issue May 9, 2024 · 0 comments · May be fixed by #7918
Open

Flax's use_memory_efficient_attention is broken #7895

entrpn opened this issue May 9, 2024 · 0 comments · May be fixed by #7918
Labels
bug Something isn't working

Comments

@entrpn
Copy link
Contributor

entrpn commented May 9, 2024

Describe the bug

I accidentally introduced a bug in this PR by making a condition on this line, which is needed when use_memory_efficient_attention=True.

Adding this bug to remind myself to put in a fix.

Reproduction

Using this example but adding use_memory_efficient_attention=True in from_pretrained.

Logs

No response

System Info

N/A

Who can help?

@pcuenca
@entrpn entrpn added the bug Something isn't working label May 9, 2024
@entrpn entrpn linked a pull request May 11, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add reshape to fix use_memory_efficient_attention in flax entrpn/diffusers
1 participant
@entrpn