-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Differentiate between NaN
and null
in the viewer
#2828
Comments
So apparently it's just that orjson.dumps([float("nan"), None])
>>> b'[null,null]' and there is no option to force it to do the opposite. To compare, I don't see an easy solution here, do you have any ideas @huggingface/dataset-viewer ? |
it's not possible to override this behavior here? dataset-viewer/libs/libcommon/src/libcommon/utils.py Lines 24 to 32 in b2c7c36
|
I am afraid the approach above will not work... Note that |
yes, i didn't manage to make it work. i think it's not possible and this is intentional, this is from
|
should we use ujson instead of orjson as in datasets? |
Also, in pyarrow doc: https://arrow.apache.org/docs/python/data.html#none-values-and-nan-handling
|
Currently, we don't do this and display and return in response
null
in both cases.From the discussion in #2797, this is agreed that it's important to let users know how to correctly treat data with these values.
This would require:
nan
values are somehow replaced withnull
.nan_count
, for other columns renamenan_count
tonull_count
:/// (my bad with the original naming)The text was updated successfully, but these errors were encountered: