Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the ROW_IDX_COLUMN constant name instead of copying the value everywhere #2798

Open
severo opened this issue May 13, 2024 · 2 comments
Open

use the ROW_IDX_COLUMN constant name instead of copying the value everywhere #2798

severo opened this issue May 13, 2024 · 2 comments
Assignees
@devesh-2002
Labels
good first issue Good for newcomers P2 Nice to have refactoring / architecture

Comments

@severo
Copy link
Collaborator

severo commented May 13, 2024

dataset-viewer/libs/libapi/src/libapi/response.py

Line 13 in 3e4f278

ROW_IDX_COLUMN = "__hf_index_id"

See the occurrences:

https://github.com/search?q=repo%3Ahuggingface%2Fdataset-viewer+__hf_index_id&type=code

Maybe do the same for __hf_fts_score too, and move the values to constants.py?
@severo severo changed the title nit: use the ROW_IDX_COLUMN constant name instead of copying the value everywhere use the ROW_IDX_COLUMN constant name instead of copying the value everywhere May 13, 2024
@devesh-2002
Copy link
Contributor

May I take this issue?

@severo
Copy link
Collaborator Author

severo commented May 13, 2024

Sure! I just assigned you the issue. Please ping me when your PR is ready!

@devesh-2002 devesh-2002 mentioned this issue May 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devesh-2002 devesh-2002

Labels
good first issue Good for newcomers P2 Nice to have refactoring / architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@severo @devesh-2002