Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to huggingface_hub 0.23.0 #2761

Open
severo opened this issue Apr 30, 2024 · 1 comment
Open

Upgrade to huggingface_hub 0.23.0 #2761

severo opened this issue Apr 30, 2024 · 1 comment
Labels
dependencies Pull requests that update a dependency file P1 Not as needed as P0, but still important/wanted

Comments

@severo
Copy link
Collaborator

severo commented Apr 30, 2024

When we do so, we have to be very careful with the new local directory which is created:

  • ensure it does not fill the disk
  • ensure it's cleaned when needed
  • ensure we have the rights to write there

internal slack discussion: https://huggingface.slack.com/archives/C01TETY5V8S/p1714492966868849

cc @Wauplin
@severo severo added dependencies Pull requests that update a dependency file P1 Not as needed as P0, but still important/wanted labels Apr 30, 2024
@severo
Copy link
Collaborator Author

severo commented Apr 30, 2024

btw: see also #2277 (we already upgraded, but I'm not sure we took advantage of DisabledRepoError

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file P1 Not as needed as P0, but still important/wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@severo