-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Printing interfaces filters incorrectly on node 18 (in server listening message) #810
Labels
Comments
8 tasks
alexanderankin
changed the title
Print interfaces in server listening message correctly on node 18
Printing interfaces filters incorrectly on node 18 (in server listening message)
May 9, 2022
ping for this |
This was referenced May 29, 2022
This issue has been inactive for 180 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This library prints ip addresses to stdout if they are ipv4 after listening. it does this by calling
os.networkInterfaces()
, which now returns4
or6
(unlike before in v17 -family <string> Either IPv4 or IPv6
).Environment Versions
$ node --version
:v18.0.0
$ http-server --version
present in latest master -http-server/bin/http-server
Line 229 in 318c55f
Steps to reproduce
Expected result
server prints:
Actual result
server prints:
Other information
I think the library should take into the current value of
process.version
when printing listening interfaces. Better yet would be to not check this at all. why not show the user (properly formatted) ipv6 links? I will submit a fix that replicates the old business logic, the new business logic could be considered in a different ticket.The text was updated successfully, but these errors were encountered: