Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artist info page: Display marked aliases in additional names box #467

Open
towerofnix opened this issue Apr 21, 2024 · 0 comments
Open

Artist info page: Display marked aliases in additional names box #467

towerofnix opened this issue Apr 21, 2024 · 0 comments

Comments

@towerofnix
Copy link
Member

In data, for the moment, these are just going to be accents on Aliases:

Artist: Toby Fox
Aliases:
- Radiation (visible)
- Toby "Radiation" Fox (visible)
- fwugradiation
# could also be "(displayed)" etc

Will require some tweaks in data processing—we probably want to drop aliasNames and instead transform an update value on aliases, similar as we're doing for contribjects (#431). Names are not visible/displayed by default, so the only updates for existing data are marking newly-displayed entries.

This will use the same additional names box UI as we've currently got. The existing title for that box (hard-coded, will need to support a slot) is "Additional and alternate names:" — and we think it could use a different message here. Some options:

  • "Also known as:"
  • "Also known by these names:"
  • "Well known as:"

We're lightly inclined against the latter (Tangle below):

...would help indicate why these lists aren't EXHAUSTIVE
i.e. we obvoiusly dont want to show all aliases in the lists, just the ones marked (visible)
but honestly it could be better to not cement any hard reasoning within the list label
leaves it more flexible u know

Probably go for the middle message, but we could consider other options too.

Via Tangle and Makin, #hsmusic-chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant