Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme_modern_rc() overwrites default point color #58

Open
z3tt opened this issue Dec 7, 2020 · 1 comment
Open

theme_modern_rc() overwrites default point color #58

z3tt opened this issue Dec 7, 2020 · 1 comment

Comments

@z3tt
Copy link

z3tt commented Dec 7, 2020

Hi Bob, thanks for your great package(s)!

I just realized, that when I call theme_modern_rc() once all my following plots have light blue dots without specifying it. I was able to track it down to your theme but it also happens when I add it via namespace and is still present after detaching the package. How can one overcome this? I think the expected behavior is to replace the color when using the theme but keep em black by default in all other cases.

Cheers,
Cédric

@z3tt
Copy link
Author

z3tt commented Dec 7, 2020

Sorry to bother you with that, just found the solution a second later via update_geom_defaults("point", list(colour = "black")). However, I still think this should be the default behavior of hrbrthemes, not something the user has to specify on its own.

andrewheiss added a commit to andrewheiss/datavizs23.classes.andrewheiss.com that referenced this issue May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant