Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkyWalking HProse plugin for auto instrument #36

Open
wu-sheng opened this issue Feb 11, 2018 · 15 comments
Open

SkyWalking HProse plugin for auto instrument #36

wu-sheng opened this issue Feb 11, 2018 · 15 comments

Comments

@wu-sheng
Copy link
Member

Since SkyWalking became an Apache project, we are going to build a more wildly support ecosystem. So I want to know:

  • Does the HProse team want to provide the plugins for hprose-java released version? If yes, which versions do you prefer to support?
@andot
Copy link
Member

andot commented Feb 13, 2018

Does the HProse team want to provide the plugins for hprose-java released version?

Yes.

which versions do you prefer to support?

2.0.30+

@wu-sheng
Copy link
Member Author

Sure. Hope to see your pull request soon. Cheer. Now, we have documents about plugins and plugin test cases. Glad you can join us.

@andot
Copy link
Member

andot commented Feb 16, 2018

What should I do? Does this project https://github.com/opentracing-contrib/java-hprose support SkyWalking?

@wu-sheng
Copy link
Member Author

I hope can provide auto instrument in SkyWalking, also means native supported, not just by OT supported.. You can find many rpc frameworks already supported. You can find plugin development guide in our document.

@wu-sheng
Copy link
Member Author

The OT API changes from time to time. I don't think it is the best way to do so.

@andot
Copy link
Member

andot commented Feb 17, 2018

Can you give me an example?

@wu-sheng
Copy link
Member Author

https://github.com/apache/incubator-skywalking/tree/master/apm-sniffer/apm-sdk-plugin

You can find all of our plugins source files. I suggest you take motan or dubbo as an example.

@wu-sheng
Copy link
Member Author

And you can find our test cases here, https://github.com/SkywalkingTest/skywalking-agent-testcases

@wu-sheng
Copy link
Member Author

@wu-sheng
Copy link
Member Author

@andot
Copy link
Member

andot commented Mar 3, 2018

看了好久,发现完全看不懂。

@wu-sheng
Copy link
Member Author

wu-sheng commented Mar 3, 2018

哪些地方看不懂?原理其实和Spring AOP类似,只是更强而已。

可以针对构造函数和方法,增加切面。然后利用我们ContextManager的APIs,要创建span或者传输carrier。这部分和OpenTracing很类似的。

@andot
Copy link
Member

andot commented Mar 8, 2018

OpenTracing 这个比较好懂,可以直接作为 hprose 的一个中间件来实现。但是 SkyWalking 的插件,没看懂该在哪儿增加切面。

@wu-sheng
Copy link
Member Author

wu-sheng commented Mar 8, 2018

hprose的任何方法都可以,他有点像spring切面。可以加载到任何包里面的类上面。

@andot
Copy link
Member

andot commented Mar 9, 2018

是指在发布的服务类上面增加切面吗?如果是在发布的服务类上面的话,好像就不用专门为hprose来写了,那应该就是通用的了啊。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants