Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schema name is not available to the schemaProvider #724

Open
jhsenjaliya opened this issue Apr 22, 2020 · 0 comments
Open

schema name is not available to the schemaProvider #724

jhsenjaliya opened this issue Apr 22, 2020 · 0 comments

Comments

@jhsenjaliya
Copy link

jhsenjaliya commented Apr 22, 2020

SchemaVersionLifecycleManager has all the required info but its not passed down to all SchemaProviders methods. some schema type like proto may require to have the schemaName or syntaxType while parsing or creating schema object internally. so its good to make such metadata accessible to schemaProvider.

some more context:
currently all methods within SchemaProvider are treated as kind of static methods where raw schema string are passed and its parsed and schema object or respective kind ( avro or proto or others) will be created on the fly to be able to perform the actual function ( like generateFields or checkCompatibility, etc...)
The above problems are surfaced when any of the methods requires access to additional metadata other than just the raw schemaText hope this explains the issue and it make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants