Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin's resources for a multilingual book overridden unexpectedly #381

Open
kakkun61 opened this issue Nov 2, 2023 · 1 comment
Open
Labels
Type: Bug Bug or Bug fixes

Comments

@kakkun61
Copy link

kakkun61 commented Nov 2, 2023

Summary

When a plugin give different resources for each language book on a multilingual book, only one set of resources is copied to _book, instead of all sets of ones.

  • HonKit version: 3.7.4

Step to reproduce

  1. Prepare a multilingual book
  2. Use a plugin that returns different resources for each language book
    • In this example “gitbook-plugin-add-js-css” is used
  3. Only last (?) resources are copied in a _book directory

Expected results

_book/gitbook/gitbook-plugin-add-js-css directory has three CSS files.

  • (hashed)-style.css (contains .root { --foo: black; })
  • (hashed)-style.css (contains .root { --foo: green; })
  • (hashed)-style.css (contains .root { --foo: red; })

Actual results

_book/gitbook/gitbook-plugin-add-js-css directory has only one CSS file.

  • 8475660b37f194a88de481bf6c110409-style.css (contains .root { --foo: black; })
@azu azu added the Type: Bug Bug or Bug fixes label Nov 2, 2023
kakkun61 added a commit to kakkun61/nmra-ja that referenced this issue Nov 2, 2023
この問題のため
honkit/honkit#381
@azu
Copy link
Member

azu commented Nov 2, 2023

I agree that this is an odd behavior.

We would need to investigate whether this is a core or plugin issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

No branches or pull requests

2 participants