Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build performance #245

Open
zoetrope opened this issue Dec 29, 2021 · 2 comments
Open

Build performance #245

zoetrope opened this issue Dec 29, 2021 · 2 comments

Comments

@zoetrope
Copy link

Summary

I'm building a book with a lot of pages with HonKit.
The build time increases exponentially with the number of pages.

  • 40 pages -> 2 seconds
  • 240 pages -> 60 seconds
  • 1500 pages -> 1 hour

Step to reproduce

  1. honkit build

I have not installed any plugins.

  • HonKit version: 3.6.23

Expected results

I expect the build time increases in proportion to the number of pages.

Additional Information

I got the profile of honkit build with pprof-nodejs.
As a result, the following functions seem to be the bottlenecks.

image

@azu
Copy link
Member

azu commented Dec 29, 2021

Nice research!

Yes, HonKit looks like do duplicated works in building.
Ideally, HonKit should build pages just one time.
However, current HonKit build a page multiply(encode page etc..)

We need to find suitable building way.

📝 Note
#243 is also related.

@Yilun-Sun
Copy link
Contributor

@azu @zoetrope I will handle it this week, the PR is comming soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants