Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not support angle brackets in link #234

Open
czp3009 opened this issue Oct 12, 2021 · 2 comments
Open

not support angle brackets in link #234

czp3009 opened this issue Oct 12, 2021 · 2 comments
Labels

Comments

@czp3009
Copy link

czp3009 commented Oct 12, 2021

Summary

current latest version not support angle brackets in link

  • HonKit version: 3.6.22

Step to reproduce

for use link with space in the url, need to round url with angle brackets

  1. source in markdown:
![](<.gitbook/assets/image (69).png>)
  1. build result in html:
<p><img src=".gitbook/assets/image (69" alt>.png&gt;)</p>)

Expected results

<p><img src=".gitbook/assets/image (69).png"/></p>
@azu azu added Type: Bug Bug or Bug fixes Type: Markdown labels Oct 15, 2021
@azu
Copy link
Member

azu commented Oct 15, 2021

Yes. HonKit/GitBook v1(legacy) markdown does not match CommonMark spec yet.
https://spec.commonmark.org/dingus/?text=!%5B%5D(%3C.gitbook%2Fassets%2Fimage%20(69).png%3E)
Related #96

@czp3009
Copy link
Author

czp3009 commented Oct 27, 2021

I made a plugin to encode url before convert to html.

https://www.npmjs.com/package/honkit-plugin-encode-link-round-with-angle-brackets

Useful for others who facing same problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants