Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roborock unexpected error initializing #92133

Closed
shbatm opened this issue Apr 27, 2023 · 7 comments · Fixed by #92131
Closed

Roborock unexpected error initializing #92133

shbatm opened this issue Apr 27, 2023 · 7 comments · Fixed by #92131

Comments

@shbatm
Copy link
Contributor

shbatm commented Apr 27, 2023

The problem

Unable to add Roborock S5 Max (no special dock). Worked with Miio integration previously. Connected fine in Roborock app, but unable to add to Home Assistant.

What version of Home Assistant Core has the issue?

2023.5.0b0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roborock

Link to integration documentation on our website

https://rc.home-assistant.io/integrations/roborock

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

2023-04-27 13:13:22.793 ERROR (MainThread) [homeassistant.components.roborock.coordinator] Unexpected error fetching roborock data: name
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 258, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/components/roborock/coordinator.py", line 77, in _async_update_data
    await asyncio.gather(
  File "/usr/src/homeassistant/homeassistant/components/roborock/coordinator.py", line 67, in _update_device_prop
    device_prop = await self.api.get_prop(device_info.device.duid)
  File "/usr/local/lib/python3.10/site-packages/roborock/api.py", line 289, in get_prop
    dock_summary = await self.get_dock_summary(device_id, status.dock_type)
  File "/usr/local/lib/python3.10/site-packages/roborock/api.py", line 251, in get_dock_summary
    if RoborockDockTypeCode.name != "RoborockDockTypeCode":
  File "/usr/local/lib/python3.10/enum.py", line 437, in __getattr__
    raise AttributeError(name) from None
AttributeError: name

Additional information

I have the debug log running, but looks like there's lots of token/private info scattered in there so I don't want to post it without sanitizing. Happy to send directly if needed.

@home-assistant
Copy link

Hey there @humbertogontijo, @Lash-L, mind taking a look at this issue as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


roborock documentation
roborock source
(message by IssueLinks)

@Lash-L
Copy link
Contributor

Lash-L commented Apr 27, 2023

Yep this is still tied in with the other errors.

For some roborock vacuums - it gives no data for the dock type and that causes the issues. This should be fixed by #92131

@Lash-L
Copy link
Contributor

Lash-L commented Apr 28, 2023

@shbatm please try with the latest beta (b2) and report back

@shbatm
Copy link
Contributor Author

shbatm commented Apr 30, 2023

Confirmed it is working in 2023.5.0b4; however, the vacuum entity is not a part of the device.

image

@Lash-L
Copy link
Contributor

Lash-L commented Apr 30, 2023

Check your logs, do you have additional errors while setting up the vacuum platform?

@shbatm
Copy link
Contributor Author

shbatm commented Apr 30, 2023

No additional errors. I think it was just a glitch when adding; after restart everything looks to be fine:

image

@Lash-L
Copy link
Contributor

Lash-L commented Apr 30, 2023

@shbatm
If you would like to - I am trying to get mop and vacuum information to be accurate per device,

Could you respond to this issue? humbertogontijo/homeassistant-roborock#261

I don't yet have info for the S5 Max

@github-actions github-actions bot locked and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants