Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intergas InComfort -- Add "state_class" to entities for long-term statistics #116357

Open
mgc8 opened this issue Apr 28, 2024 · 3 comments
Open

Comments

@mgc8
Copy link

mgc8 commented Apr 28, 2024

The problem

When using the "Intergas InComfort" integration, there are a number of interesting sensor entities created (temperature, pressure), however none of them has the required state_class configured, thus the data is only kept for a little time, then lost as soon as the database purge runs. Can we please have the correct state_class added to these entities, so that they are saved in the long-term statistics?

What version of Home Assistant Core has the issue?

2024.3.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

Intergas InComfort

Link to integration documentation on our website

https://www.home-assistant.io/integrations/incomfort/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@home-assistant
Copy link

Hey there @zxdavb, mind taking a look at this issue as it has been labeled with an integration (incomfort) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of incomfort can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign incomfort Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


incomfort documentation
incomfort source
(message by IssueLinks)

@mib1185
Copy link
Contributor

mib1185 commented Apr 28, 2024

Hi @mgc8

This sounds more like an feature request?
Please use the feature request section of our forum to contribute on existing or create new feature requests.
For sure, contributions are always welcome, so please feel free to create a PR on your own.

Thanks! 👍

@mgc8
Copy link
Author

mgc8 commented Apr 29, 2024

Hi @mib1185 ,

Not sure this is much of a "feature", just a missing parameter in the way the sensors are created. If I add it on the forum, I'm afraid it'll get buried under the many more pressing feature requests being discussed...

I'd be happy to create a patch and submit a PR for this, are there any requirements to be aware of apart from what is shown here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants