-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect delegation from String
to ViewString
#541
Comments
If I do the proposed change the test suite fails for the following reason: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The GAP library has a bewildering number of functions for printing/viewing/displaying objects to the terminal or into a string. There is a strict hierarchy how methods for the various involved operations may delegate, described in the GAP reference manual.
The following method violates this:
homalg_project/MatricesForHomalg/gap/HomalgMatrix.gi
Lines 3914 to 3918 in 698bcb6
To fix this, just install the
ViewString
method forIsHomalgMatrix
as a method forString
instead and then delegate "the other way around".The text was updated successfully, but these errors were encountered: