This repository has been archived by the owner on Feb 3, 2023. It is now read-only.
remove newrelic from holochain #2143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what was newrelic there for, and why take it out? |
We added it for debugging purposes to try and track down some cross-process problems with the tracing it offeres, however it's causing problems in our holoport build chain so we need to clean it out for now. In the "production" context rewrelic doesn't make any sense for holochain at all because it's centralized monitoring. It may make sense to add back into sim2h_server which is a centralized service so that it can be monitored. |
|
This will need to be removed from holochain tracing aswell. |
|
obsolete |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Removes new-relic building completely from conductor for now.
testing/benchmarking notes
( if any manual testing or benchmarking was/should be done, add notes and/or screenshots here )
followups
( any new tickets/concerns that were discovered or created during this work but aren't in scope for review here )
changelog
documentation