Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]import of youth games breaks #2065

Closed
gerste2020 opened this issue May 6, 2024 · 2 comments
Closed

[BUG]import of youth games breaks #2065

gerste2020 opened this issue May 6, 2024 · 2 comments
Assignees
@wsbrenk
Labels
status: needs test might be fixed, needs test before closing
Milestone
8.0

Comments

@gerste2020
Copy link

gerste2020 commented May 6, 2024 •
edited
Loading

20240506 ho download error
Describe the bug
import of youth games breaks when a friendly youth game ran into shootoot, I think
error importing youth friendly with penalty shootout wore than 22 shooters.txt
20240506 ho download
20240506 ho jugies

To Reproduce
see attached report or ask angie, if it is possible to create imidiatly a game with penalty shootout with more than 20 shooters

Screenshots
attached

Platform information:
windows10 22H2 Build 19045.4291 and before
HO version 8.0 (r613)
on JAVA Eclipse Temurin 17.0.6

Additional context
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Hey, thanks for opening your first issue! 🙂
Be sure to check out the wiki and the HT forum for support.

@wsbrenk wsbrenk self-assigned this May 6, 2024
@wsbrenk wsbrenk added this to the 8.0 milestone May 6, 2024
@wsbrenk
Copy link
Collaborator

wsbrenk commented May 6, 2024

In V8.0 i will try to truncate the match report length to the maximum column length of the current database version.

In V9 i will make the match report column length longer than 20000 characters.

wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2024
@wsbrenk
ho-dev#2065 truncate match report if string is too long for database …
45fb196 
…column
@wsbrenk wsbrenk mentioned this issue May 6, 2024
Merged
2 tasks
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2024
@wsbrenk
Merge branch 'refs/heads/ho-dev#2065' into #2065_HO9
f115491 
# Conflicts:
#	gradle.properties
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2024
@wsbrenk
ho-dev#2065 set maximum match report size to 40000 characters
b62657f
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 6, 2024
@wsbrenk
ho-dev#2065 new column "nullable" in sql editor table
fe8c215
@wsbrenk wsbrenk mentioned this issue May 6, 2024
Merged
2 tasks
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 8, 2024
@wsbrenk
ho-dev#2065 rename AbstractTable.truncateString
0b88e37
wsbrenk added a commit to wsbrenk/HO that referenced this issue May 8, 2024
@wsbrenk
ho-dev#2065 rename AbstractTable.truncateString
00343a6
wsbrenk added a commit that referenced this issue May 8, 2024
@wsbrenk
#2065 truncate match report if string is too long for database column (…
d6ff6c5 
…#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString
@wsbrenk wsbrenk added the status: needs test might be fixed, needs test before closing label May 8, 2024
wsbrenk added a commit that referenced this issue May 10, 2024
@wsbrenk @tychobrailleur
#2065 Increase match report column size in database (#2067)
1cb63b5 
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2065 truncate match report if string is too long for database column

* #2065 set maximum match report size to 40000 characters

* #2065 new column "nullable" in sql editor table

* #2065 rename AbstractTable.truncateString

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
@wsbrenk wsbrenk closed this as completed May 20, 2024
wsbrenk added a commit that referenced this issue May 21, 2024
@wsbrenk @tychobrailleur
Merge/rel8 (#2071)
33b965b 
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
wsbrenk added a commit that referenced this issue Jun 6, 2024
@wsbrenk @tychobrailleur
Merge/ v8 (#2080)
fb8bbd7 
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
wsbrenk added a commit that referenced this issue Jun 23, 2024
@wsbrenk @tychobrailleur
Release ho8 (#2086)
c1bd700 
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
wsbrenk added a commit that referenced this issue Jun 23, 2024
@wsbrenk @tychobrailleur
Update changelog (#2087)
495da9d 
* #1797 create beta (#2052)

* Fix build (#2054)

* #1797 create beta

* #1797 fix build

* #2055 fix slow opening of team analyzer panel (#2056)

* update release_notes.md

* #2055 remove unused info label

* #2055 remove unused info label (code analysis results)

* #2055 release_notes.md

* #2055 release_notes.md

* Use SwingWorker to properly fix hanging UI. (#2057)

* Update dependencies, in particular OkHttp to fix CVE. (#2058)

This fixes CVE-2023-3635, cf. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-3635

* #2059 fix currency error in team analyzer's total salary column (#2060)

* #2063 add 5 new countries to international flags module (#2064)

* #2063 add 5 new countries to international flags module

* #2063 add 5 new countries to international flags module (review)

* release_notes.md translator

* #2063 the flag files

* #2065 truncate match report if string is too long for database column (#2066)

* #2065 truncate match report if string is too long for database column

* #2065 rename AbstractTable.truncateString

* #2063 Guinea (#2068)

* #2063 download missing world details (#2070)

* #2063 download missing world details

* #2063 download missing world details

* #2063 download missing world details

* #2063 fix database error on matches reload

* #2069 (#2072)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 Initialize series table if no matches are played yet (#2073)

* #2069 reduce space between team summary labels

* #2069 release_notes.md

* #1455 initialize series table if no matches are played yet

* #1455 fix initial order of series table

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #1455 review

* #2074 update ratings when team spirit is changed (#2075)

* #1455 review

* #2074 update ratings when team spirit is changed

* #2076 sorting of youth table average column (#2077)

* #2078 ts forecast loads all trainer data (#2079)

* #2078 ts forecast loads all trainer data

* #2078 release_notes.md

* Create `stable` tag when `tag_stable` is created. (#2083) (#2085)

* Release/8 (#2084)

* Create `stable` tag when `tag_stable` is created.

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>

* release stable HO8

* release stable HO8

---------

Co-authored-by: Sébastien Le Callonnec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wsbrenk wsbrenk

Labels
status: needs test might be fixed, needs test before closing
Projects
None yet
Milestone
8.0
Development

No branches or pull requests
2 participants
@wsbrenk @gerste2020