-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Download F11 Old League Data, No Data Shown on League Data Tab #1413
Comments
@masterpatje did you try to select some of the listed seasons like this: |
could you please check if there are some errors in your log file (%APPDATA%/HO/logs) |
=====Error log on 21-03-2021 ======HO-2021-02-23 log -Today I again tried to download data and included season 69- 14:44:14 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) 14:44:14 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) 14:44:17 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) 14:44:17 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) 14:44:17 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) 14:44:21 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLDataException: data exception: invalid datetime format 14:44:21 [Info] core.training.TrainingWeekManager: Next week training date: 2022-03-25 01:05:00 14:45:22 [Error] core.db.JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unknown token: =======Output log (date 23-03-2022) [Error] JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) [Error] JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) [Debug] TrainingManager: HOVerwaltung model changed => TrainingManager and TrainingWeekManager are reinitialized [Error] JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) [Error] JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unexpected token: 17 required: ) [Debug] OnlineWorker: Get Lineup : 690594140 [Info] TrainingWeekManager: Next week training date: 2022-03-25 01:05:00 [Error] JDBCAdapter: JDBCAdapter.executeUpdate : java.sql.SQLSyntaxErrorException: unknown token: [Info] LeaguePromotionHandler: Status of league: 14 : {"status_code": 1, "status_desc": "NOT_AVAILABLE", "nbBlocks": 14, "nbBlocksReady": 0, "nbBlocksInProgress": 0} |
I don't know if I should share the log file in the comments? So please let me know how to provide you the information? Please note the latest line in output log, referencing to LeaguePromotionHandler and text "not available". Do you consider this related to the problem I am having or is it referencing to another module? (see line below) |
@masterpatje thanks for the log info - it is helpful. and yes the not available is related to your other ticket. |
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
the new version should fix the errors in the logs - i'm not sure if they are responsible for your empty series panel |
Yes, in build 6.0.253 the issue is fixed! Now league data is shown (!) There are still 2 (minor) bugs that I encountered, that might be related to each other:
HO-2022-03-26 and output.log are included below: |
Again bith logs are included |
I also did a test by fully de-installing the application and manually deleting the files in the Roaming data HO folder located under AppData/Roaming/HO. When I tried to download and include all seasonal data by checking Old League Data box, but not specifying which seasons to included. I again got the please wait... 50% orange bar. This time no League Data is shown (steps are the same as in previous comment screenshots). I included the LOG files below, they are completely different from last output: PS. Next TEST; |
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@masterpatje thanks again for that report. i hope now, that you can start from scratch without errors. |
Thanks a lot for build v254.
TO DO: Now I will check by doing a second download (with previous League Data). Output file: |
@masterpatje i will see if i could get the leagues of your team from ancient series |
Thanks @wsbrenk . And also for fixing previous bugs. Really great work. Please tell me if you want me to test something specific. I will do so and give you the results. I think that this button below (image) is still not working, but maybe better if I put it in a different bug thread, because it is not connected to the Download function were No League Data was shown. Please let me know if you want me to open a new one. |
until now, i never had a look on this part of the organizer. i fear this function might be broken. |
matchdetails file contains info about league:
|
I might have a different idea. I have older .hrf files. Would it be possible to extract Old League Data from it? For example. When doing a fresh install you can choose either to first import older files before downloading latest .hrf Otherwise manually entering league numbers is maybe the easiest (less user friendly) solution, but for sure will do the trick. |
@masterpatje thank you very much for great test report.
|
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
@wsbrenk good idea that you are disabling it (bug 2). That will make clear that you can't download Old League Data on the first download. Request: For clarification purposes include a message that the option to download Old League Data is available after the first download is completed. Festure/Bug 3: On the initial download also the "League Data tab" stays empty (see image below). Maybe you can include the Current League Data from the initial download? This will look nicer for people that want to use Hattrick Organizer for the first time. Otherwise it is confusing that League Data tab is empty. |
wsbrink: "concerning feature 2: the download of old series is needed only one time, since the data is stored in the database. downloading them with each download would be to heavy" Referencing to "Feature 2: It would be nice if you check the checkbox for "Old League Data" to by default include all previous seasons. This would also fix bug 1." I think that I explained myself incorrectly. What I meant is that when selecting the checkbox "Old League Data" you automatically include all previous seasons by default. As you said it is used only one time, only when you want to download previous seasons. So in this way it is not included in every download (would not make sense), but I would suggest downloading all seasons by default only when checking the box below, that was my suggestion. |
@masterpatje at the moment hattrick has not yet determined the current fixtures of the upcoming season. i hope that users starting next week will see their fixtures |
Oke I will do a fresh install next week and check if after 1st week of the league, after I played the first match, that League Data it is available. The league is however already determined, but this data is not included in the .hrf downloadable data? |
@masterpatje the teams are already there, but not the fixtures. |
Oke did some testwork (v261):
[Info] HO: users.json file not found => a new one will be created
Lastly I created the bug/feature request #1434 the checkbox "old league data" for functionally to include all seasons. |
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
…1429) Co-authored-by: wsbrenk <zissener-weg-brenk.de>
* ho-dev#1413 disable load of old fixtures in initial download * ho-dev#1413 disable load of old fixtures in initial download * ho-dev#1413 reload old seasons with reuse settings check box Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
…#1421) Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Co-authored-by: wsbrenk <zissener-weg-brenk.de>
…1429) Co-authored-by: wsbrenk <zissener-weg-brenk.de>
* ho-dev#1413 disable load of old fixtures in initial download * ho-dev#1413 disable load of old fixtures in initial download * ho-dev#1413 reload old seasons with reuse settings check box Co-authored-by: wsbrenk <zissener-weg-brenk.de>
…ho-dev#1436) Co-authored-by: wsbrenk <zissener-weg-brenk.de>
Describe the bug
No League Data shown after download of data. First data is downloaded via the preferred "F11 method" menu as indicated in the first image. But when I check the League Data tab no data is shown (second image).
In #1412 I reported that the loop of importing league data never ends. This might be connected to this bug.
To Reproduce
Steps to reproduce the behavior:
Screenshots
Platform information:
Additional context
I also had this problem in HO 5.2. I did a clean install with that version, prior to updating to 6.0.
In 3.0 functionality of data download worked. Leagues 56 untill 69 are shown.
The text was updated successfully, but these errors were encountered: