Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Completely wrong data in OrdersApi::getAllOrders() orderLines field #19

Open
gio-vlasov opened this issue Feb 7, 2024 · 0 comments
Open

Completely wrong data in OrdersApi::getAllOrders() orderLines field #19

gio-vlasov opened this issue Feb 7, 2024 · 0 comments

Comments

@gio-vlasov
Copy link

gio-vlasov commented Feb 7, 2024 •
edited

It sets \Walmart\Models\MP\US\Orders\RefundLinesType instead of Walmart\Models\MP\US\Orders\OrderLinesType

Here:

walmart-api-php/src/Models/MP/US/Orders/Order.php

Line 63 in 575b611

'orderLines' => '\Walmart\Models\MP\US\Orders\RefundLinesType',

@gio-vlasov gio-vlasov changed the title Completely wrong data returned in getAllOrders() orderLines field Completely wrong data in OrdersApi::getAllOrders() orderLines field Feb 7, 2024
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
@dpash
Replace the Order/orderLines type
64a827c 
The `orderLines` type in the schema was incorrectly set to be `RefundLinesType`
which meant that many of the values were not exposed to the user.

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
@dpash
Replace the Order/orderLines type
f5697ee 
This is the result of customising the schema after the previous commit

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 19, 2024
@dpash
Replace the Order/orderLines type
d607b3d 
This is the result of generating the API from the schema

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
dpash added a commit to dpash/walmart-api-php that referenced this issue Feb 27, 2024
@dpash
Replace the Order/orderLines type
bd81ab0 
Turns out I missed one incorrect type, so this should hopefully fix that too

Fixes highsidelabs#13, fixes highsidelabs#17, fixes highsidelabs#19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gio-vlasov